Re: Rb_tree constructor optimization

[Jonathan Wakely <jwakely at redhat dot com>]

On 17/05/18 16:10 +0100, Jonathan Wakely wrote:
> On 15/05/18 07:30 +0200, François Dumont wrote:
> > Here it is again even more simplified. Should I backport the Debug 
> > mode fix to 8 branch ?
>
> Yes, please do backport the include/debug/* changes.
>
>
> >     * include/bits/stl_tree.h
> >     (_Rb_tree_impl(_Rb_tree_impl&&, _Node_allocator&&)): New.
> >     (_Rb_tree(_Rb_tree&&, _Node_allocator&&, true_type)): New, use latter.
> >     (_Rb_tree(_Rb_tree&&, _Node_allocator&&, false_type)): New.
> >     (_Rb_tree(_Rb_tree&&, _Node_allocator&&)): Adapt, use latters.
> >     * include/debug/map.h
> >     (map(map&&, const_allocator_type&)): Add noexcept qualitication.
> >     * include/debug/multimap.h
> >     (multimap(multimap&&, const_allocator_type&)): Add noexcept 
> > qualification.
> >     * include/debug/set.h
> >     (set(set&&, const_allocator_type&)): Add noexcept qualitication.
> >     * include/debug/multiset.h
> >     (multiset(multiset&&, const_allocator_type&)): Add noexcept 
> > qualification.
> >     * testsuite/23_containers/map/cons/noexcept_default_construct.cc:
> >     Add checks.
> >     * testsuite/23_containers/map/cons/noexcept_move_construct.cc:
> >     Add checks.
> >     * testsuite/23_containers/multimap/cons/noexcept_default_construct.cc:
> >     Add checks.
> >     * testsuite/23_containers/multimap/cons/noexcept_move_construct.cc:
> >     Add checks.
> >     * testsuite/23_containers/multiset/cons/noexcept_default_construct.cc:
> >     Add checks.
> >     * testsuite/23_containers/multiset/cons/noexcept_move_construct.cc:
> >     Add checks.
> >     * testsuite/23_containers/set/cons/noexcept_default_construct.cc:
> >     Add checks.
> >     * testsuite/23_containers/set/cons/noexcept_move_construct.cc:
> >     Add checks.
> >
> > Ok to commit ?
>
> Yes, OK for trunk - thanks.

I'm seeing lots of new testsuite failures after this commit, see
https://gcc.gnu.org/ml/gcc-testresults/2018-05/msg02025.html