This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: PR85817
- From: Richard Biener <rguenther at suse dot de>
- To: Prathamesh Kulkarni <prathamesh dot kulkarni at linaro dot org>
- Cc: gcc Patches <gcc-patches at gcc dot gnu dot org>
- Date: Fri, 18 May 2018 10:51:11 +0200 (CEST)
- Subject: Re: PR85817
- References: <CAAgBjMmAmZHjNKJkkzjJU_QmGH-FQ5i2qawN8PYuMj7-n82=9A@mail.gmail.com>
On Fri, 18 May 2018, Prathamesh Kulkarni wrote:
> Hi,
> In r260250, the condition
>
> if (integer_zerop (retval))
> continue;
>
> was added before checking retval was of pointer type which caused
> functions having return type apart from void *, to be marked as
> malloc. The attached patch gets rid of the above check since we do not
> wish to mark function returning NULL as malloc.
> Also, it adds a check to return false if all args to phi are 0,
> although I am not sure if this'd actually trigger in practice since
> constant propagation should have folded the phi into constant 0
> already.
>
> Bootstrap+test in progress on x86_64-linux-gnu and aarch64-linux-gnu.
> OK to commit if passes ?
OK.
Thanks,
Richard.