This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [libstdc++, PATCH] PR libstdc++/83140 - assoc_legendre returns negated value when m is odd.
Hi Ed,
> On 05/10/2018 01:44 PM, Rainer Orth wrote:
>> Hi Ed,
>>
>>>>> 2018-05-07 Edward Smith-Rowland <3dw4rd@verizon.net>
>>>>>
>>>>> PR libstdc++/83140 - assoc_legendre returns negated value when m is
>>>>> odd
>>>>> * include/tr1/legendre_function.tcc (__assoc_legendre_p): Add
>>>>> __phase
>>>>> argument defaulted to +1. Doxy comments on same.
>>>>> * testsuite/special_functions/02_assoc_legendre/
>>>>> check_assoc_legendre.cc: Regen.
>>>>> * testsuite/tr1/5_numerical_facilities/special_functions/
>>>>> 02_assoc_legendre/check_tr1_assoc_legendre.cc: Regen.
>> something went badly wrong with the regeneration of this last file: both
>> in your attached patch and in what you checked in, the file is empty.
>>
>> Rainer
>>
> I had hosed up the ChangeLog!
>
> CL change committed as 260149.
>
> New Log attached.
you misunderstood: it's not the ChangeLog that had a problem (well; I
don't think you you break long path names in there, but that's a nit at
most), but the regeneration step went wrong and you checked an *empty
testcase* into the repo
-rw-r--r-- 1 ro gcc 0 May 11 15:09 libstdc++-v3/testsuite/tr1/5_numerical_facilities/special_functions/02_assoc_legendre/check_value.cc
which always causes a failure:
+FAIL: tr1/5_numerical_facilities/special_functions/02_assoc_legendre/check_value.cc (test for excess errors)
Excess errors:
Undefined first referenced
symbol in file
main /usr/lib/crt1.o
ld: fatal: symbol referencing errors
+UNRESOLVED: tr1/5_numerical_facilities/special_functions/02_assoc_legendre/chec
k_value.cc compilation failed to produce executable
Please fix.
Rainer
--
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University