This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH, PR82428] Add __builtin_goacc_{gang,worker,vector}_{id,size}
- From: Tom de Vries <Tom_deVries at mentor dot com>
- To: Jakub Jelinek <jakub at redhat dot com>
- Cc: Thomas Schwinge <thomas at codesourcery dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Thu, 3 May 2018 12:36:36 +0200
- Subject: Re: [PATCH, PR82428] Add __builtin_goacc_{gang,worker,vector}_{id,size}
- References: <7241cb5e-dc7d-8feb-91e0-d11d7ac0882e@mentor.com> <20180106113607.GL1833@tucnak> <b1640191-d342-9ec3-feb3-bf9d3abebb06@mentor.com> <7eb1631a-b4db-e966-218b-762ec8ce738e@mentor.com> <20180115100547.GV2063@tucnak> <6d5f2bbf-8555-99b8-065c-666640f6a03a@mentor.com> <20180115104423.GW2063@tucnak> <cdec8aa4-c0bf-f805-0dd2-f9bee80e4211@mentor.com> <20180115112524.GX2063@tucnak> <2e1df3d2-7238-9c1f-fd6e-46a3cbed84e6@mentor.com> <20180117175118.GW2063@tucnak> <86cadd6e-aac1-2df0-ca5b-d1d1bf726f1b@mentor.com>
On 01/18/2018 09:55 AM, Tom de Vries wrote:
diff --git a/libgomp/testsuite/libgomp.oacc-c-c++-common/gang-static-2.c b/libgomp/testsuite/libgomp.oacc-c-c++-common/gang-static-2.c
index 6de739a..e273a79 100644
--- a/libgomp/testsuite/libgomp.oacc-c-c++-common/gang-static-2.c
+++ b/libgomp/testsuite/libgomp.oacc-c-c++-common/gang-static-2.c
@@ -1,25 +1,23 @@
-/* { dg-do run { target openacc_nvidia_accel_selected } } */
-/* This code uses nvptx inline assembly guarded with acc_on_device, which is
- not optimized away at -O0, and then confuses the target assembler.
- { dg-skip-if "" { *-*-* } { "-O0" } { "" } } */
-
#include <assert.h>
#include <openacc.h>
+#include <gomp-constants.h>
Hi,
it seems I've broken installed testing of libgomp with this patch. The
compiler cannot find gomp-constants.h.
In the build-area testing setup, the compiler can find gomp-constants.h
because in libgomp.exp we find:
...
if { $blddir != "" } {
...
# The top-level include directory, for gomp-constants.h.
lappend ALWAYS_CFLAGS "additional_flags=-I${srcdir}/../../include"
}
...
but this line is not active for installed testing.
Patch below fixes this.
Is this approach ok for trunk?
Thanks,
- Tom
Index: libgomp/testsuite/lib/libgomp.exp
===================================================================
--- libgomp/testsuite/lib/libgomp.exp (revision 259880)
+++ libgomp/testsuite/lib/libgomp.exp (working copy)
@@ -186,9 +186,9 @@ proc libgomp_init { args } {
lappend ALWAYS_CFLAGS "additional_flags=-B${blddir}/.libs"
lappend ALWAYS_CFLAGS "additional_flags=-I${blddir}"
lappend ALWAYS_CFLAGS "ldflags=-L${blddir}/.libs"
- # The top-level include directory, for gomp-constants.h.
- lappend ALWAYS_CFLAGS "additional_flags=-I${srcdir}/../../include"
}
+ # The top-level include directory, for gomp-constants.h.
+ lappend ALWAYS_CFLAGS "additional_flags=-I${srcdir}/../../include"
lappend ALWAYS_CFLAGS "additional_flags=-I${srcdir}/.."
# For build-tree testing, also consider the library paths used for
builing.