This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH, rs6000] Add missing vec_max tests
- From: Peter Bergner <bergner at vnet dot ibm dot com>
- To: Carl Love <cel at us dot ibm dot com>
- Cc: Segher Boessenkool <segher at kernel dot crashing dot org>, gcc-patches at gcc dot gnu dot org, David Edelsohn <dje dot gcc at gmail dot com>, Bill Schmidt <wschmidt at linux dot vnet dot ibm dot com>
- Date: Mon, 30 Apr 2018 11:04:52 -0500
- Subject: Re: [PATCH, rs6000] Add missing vec_max tests
- References: <1525102564.13190.1.camel@us.ibm.com>
On 4/30/18 10:36 AM, Carl Love wrote:
> -/* We generate xxlor instructions for many reasons other than or'ing vector
> - operands or calling __builtin_vec_or(), which means we cannot rely on
> - their usage counts being stable. Therefore, we just ensure at least one
> - xxlor instruction was generated. */
> -/* { dg-final { scan-assembler "xxlor" } } */
[snip]
> +/* { dg-final { scan-assembler-times "xxlor" 25 } } */
Please do not change back to counting xxlor insns. We used to do that before
my change in March where I added the comment you are removing that explains
the folly of trying to count them.
Peter