This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Fix aarch64 ILP32 ICE with vaarg gimplified code
On Fri, Apr 27, 2018 at 10:02:11AM +0100, Richard Biener wrote:
> On Fri, 27 Apr 2018, Kyrill Tkachov wrote:
>
> >
> > On 26/04/18 15:04, Christophe Lyon wrote:
> > > On 26 April 2018 at 15:41, Richard Biener <rguenther@suse.de> wrote:
> > > > On Thu, 26 Apr 2018, Christophe Lyon wrote:
> > > >
> > > >> On 26 April 2018 at 14:09, Richard Biener <rguenther@suse.de> wrote:
> > > >> >
> > > >> > Seen by Christophe Lyon, verified with a cross that this fixes the
> > > >> > issue.
> > > >> >
> > > >> > aarch64 people, can you please test & commit this?
> > > >> >
> > > >>
> > > >> As I have just written in bugzilla, this patch avoids an ICE when
> > > >> compiling newlib's sysopen.i,
> > > >> but I still see a similar crash when compiling vfprintf.i.
> > > >
> > > > There's a similar case still left. Complete patch:
> > > >
> > > With this version, the toolchain build completes, but I didn't run
> > > make check, nor tried aarch64-linux-gnu.
> > >
> >
> > A bootstrap and test on aarch64-none-linux-gnu shows no problems.
> > I don't know if there was a rationale for having the conversion to
> > intDI_type_node.
>
> If that is somehow a required detail for SImode pointers then
> there needs to be a conversion from the pointer to uintSI_type_node
> before then extending to intDI_type_node. uintSI to match the
> setting of POINTERS_EXTEND_UNSIGNED for aarch64.
Looks OK to me. Thanks for the patch and explanation. Kyrill, if you
have it in tree you can commit it if that's what is wanted.
Thanks,
James