This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Fix bbpart handling of EH pads (PR rtl-optimization/85393)
- From: Eric Botcazou <ebotcazou at adacore dot com>
- To: Jakub Jelinek <jakub at redhat dot com>
- Cc: Jeff Law <law at redhat dot com>, gcc-patches at gcc dot gnu dot org
- Date: Fri, 13 Apr 2018 21:32:07 +0200
- Subject: Re: [PATCH] Fix bbpart handling of EH pads (PR rtl-optimization/85393)
- References: <20180413172019.GF8577@tucnak>
> This works nicely if the landing pad bb hasn't been really modified much,
> in particular it still needs to contain only the instructions emitted
> by expand_dw2_landing_pad_for_region function call and then an unconditional
> jump or at least single successor and nothing else in the bb.
How is that supposed to work for SJLJ though?
> 2018-04-13 Jakub Jelinek <jakub@redhat.com>
>
> PR rtl-optimization/85393
> * bb-reorder.c (fix_up_crossing_landing_pad): In new_bb emit just
> a label and unconditional jump to old_bb, rather than
> expand_dw2_landing_pad_for_region insn(s) and jump to single_succ
> basic block.
OK, but also make expand_dw2_landing_pad_for_region private so that the same
mistake is not made again in the future.
--
Eric Botcazou