This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [AARCH64] Neon vld1_*_x3, vst1_*_x2 and vst1_*_x3 intrinsics
- From: Sameera Deshpande <sameera dot deshpande at linaro dot org>
- To: James Greenhalgh <james dot greenhalgh at arm dot com>
- Cc: Christophe Lyon <christophe dot lyon at linaro dot org>, gcc-patches <gcc-patches at gcc dot gnu dot org>, Richard Earnshaw <Richard dot Earnshaw at arm dot com>, nd at arm dot com, sudi dot das at arm dot com
- Date: Fri, 13 Apr 2018 14:39:32 +0000
- Subject: Re: [AARCH64] Neon vld1_*_x3, vst1_*_x2 and vst1_*_x3 intrinsics
- References: <CAAdirjxgB2dzBN973aesZCBVsv-N20dkrzC8Yoer0Jtb+zZ5ZA@mail.gmail.com> <CAKdteOZqEDT2yNM7jpjCEULFJXcqxnamT1T5jzEJvVaxzUbtkA@mail.gmail.com> <CAAdirjwDY1fXfG1hc4Bv94+g6a9ONOeUjEKqz5vhf5pU9vvbXQ@mail.gmail.com> <CAKdteOaEdhm8CCpBr_vavbWEgbTPm_iux4KjJAv7Bz5_5kkW=A@mail.gmail.com> <20180413143421.GA30909@arm.com>
On Fri 13 Apr, 2018, 8:04 PM James Greenhalgh, <james.greenhalgh@arm.com>
wrote:
> On Fri, Apr 06, 2018 at 08:55:47PM +0100, Christophe Lyon wrote:
> > Hi,
> >
> > 2018-04-06 12:15 GMT+02:00 Sameera Deshpande <
> sameera.deshpande@linaro.org>:
> > > Hi Christophe,
> > >
> > > Please find attached the updated patch with testcases.
> > >
> > > Ok for trunk?
> >
> > Thanks for the update.
> >
> > Since the new intrinsics are only available on aarch64, you want to
> > prevent the tests from running on arm.
> > Indeed gcc.target/aarch64/advsimd-intrinsics/ is shared between the two
> targets.
> > There are several examples on how to do that in that directory.
> >
> > I have also noticed that the tests fail at execution on aarch64_be.
>
> I think this is important to fix. We don't want the big-endian target to
> have
> failing implementations of the Neon intrinsics. What is the nature of the
> failure?
>
> From what I can see, nothing in the patch prevents using these intrinsics
> on big-endian, so either the intrinsics behaviour is wrong (we have a wrong
> code bug), or the testcase expected behaviour is wrong.
>
> I don't think disabling the test for big-endian is the right fix. We should
> either fix the intrinsics, or fix the testcase.
>
> Thanks,
> James
>
> Hi James,
As the tests assume the little endian order of elements while checking the
results, the tests are failing for big endian targets. So, the failures are
not because of intrinsic implementations, but because of the testcase.
- Thanks and regards,
Sameera D.