This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] sched-deps: respect deps->readonly in macro-fusion (PR 84566)

From: Vladimir Makarov <vmakarov at redhat dot com>
To: Andrey Belevantsev <abel at ispras dot ru>, Alexander Monakov <amonakov at ispras dot ru>, gcc-patches at gcc dot gnu dot org
Date: Wed, 11 Apr 2018 10:19:37 -0400
Subject: Re: [PATCH] sched-deps: respect deps->readonly in macro-fusion (PR 84566)
References: <alpine.LNX.2.20.13.1804101323460.24851@monopod.intra.ispras.ru> <0cd02247-9afa-f01e-c88b-935c6150f781@ispras.ru>



On 04/11/2018 06:19 AM, Andrey Belevantsev wrote:

On 10.04.2018 13:40, Alexander Monakov wrote:

Hi,

this fixes a simple "regression" under the qsort_chk umbrella: sched-deps
analysis has deps->readonly flag, but macro-fusion code does not respect it
and mutates instructions. This breaks an assumption in sel_rank_for_schedule
and manifests as qsort checking error.

Since sched_macro_fuse_insns is only called to set SCHED_GROUP_P on suitable
insns, guard the call with !deps->readonly.

Bootstrapped/regtested on x86_64 with sel-sched active and
--with-cpu=sandybridge to exercise macro-fusion code and verified on aarch64
cross-compiler that the failing testcase given in the PR is fixed.

OK to apply?

Fine with me but you need a scheduler maintainer approval.

Ok with me.  Thanks for the patch.

References:
- [PATCH] sched-deps: respect deps->readonly in macro-fusion (PR 84566)
  - From: Alexander Monakov
- Re: [PATCH] sched-deps: respect deps->readonly in macro-fusion (PR 84566)
  - From: Andrey Belevantsev

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]