Re: [og7] vector_length extension part 2: Generalize state propagation and synchronization

[Tom de Vries <Tom_deVries at mentor dot com>]

On 03/22/2018 06:47 PM, Cesar Philippidis wrote:
> On 03/22/2018 10:39 AM, Tom de Vries wrote:
> > On 03/02/2018 05:55 PM, Cesar Philippidis wrote:
> > > +  rtx red_partition; /* Similar to bcast_partition, except for vector
> > > +            reductions.  */
> >
> > Shouldn't this be in "[og7] vector_length extension part 3: reductions"?
>
> Maybe. But keep in mind, with the exception of the bar.sync and maxntid
> changes you requested, I don't think the vector length patch makes sense
> to go in as individual hunks. Maybe I could split out the new
> TARGET_GOACC_ADJUST_PARALLELISM hook in part 4 into a separate patch.
> But, at the same time, if something isn't being used, what's the point
> of going through that extra work?

Because patches that are split into logically consistent parts are easy 
to review, and easy to analyze and fix or undo when bisected back to. 
And yes, that's extra work.

Thanks,
- Tom