This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [RFC Patch], PowerPC memory support pre-gcc9, Version 2, Patch #3
- From: Segher Boessenkool <segher at kernel dot crashing dot org>
- To: Michael Meissner <meissner at linux dot vnet dot ibm dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>, David Edelsohn <dje dot gcc at gmail dot com>, Bill Schmidt <wschmidt at linux dot vnet dot ibm dot com>
- Date: Thu, 22 Mar 2018 10:03:55 -0500
- Subject: Re: [RFC Patch], PowerPC memory support pre-gcc9, Version 2, Patch #3
- References: <20180322120346.GA7987@ibm-tiger.the-meissners.org> <20180322121636.GC20027@ibm-tiger.the-meissners.org>
Hi!
On Thu, Mar 22, 2018 at 08:16:36AM -0400, Michael Meissner wrote:
> This match renames the d-form mode support function and makes it more general.
> It was originally written to test whether we have the ISA 3.0 new D*-form
> instruction, but I believe in the future, I will want to use it also for GPR
> and tradiational floating point registers.
>
> I have built bootstrap compilers with the first 4 patches including this patch
> on both big and little endian power8 systems. There were no regressions.
>
> 2018-03-21 Michael Meissner <meissner@linux.vnet.ibm.com>
>
> * config/rs6000/rs6000.c (mode_supports_d_form): Rename
> mode_supports_vmx_dform to mode_supports_d_form. Add an optional
> argument to say which reload register class to use. Chagne all
(typo, "change").
> callers to pass in the RELOAD_REG_VMX class explicitly.
> (rs6000_secondary_reload): Likewise.
> (rs6000_preferred_reload_class): Likewise.
> (rs6000_secondary_reload_class): Likewise.
So it is called "mode_supports_d_form" but it actually returns true for
*any* offset form?
> +mode_supports_d_form (machine_mode mode,
> + enum rs6000_reload_reg_type rt = RELOAD_REG_ANY)
Does the default argument make the interface simpler, or more complex?
Segher