This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Use non-throwing is_directory in filesystem::create_directory

From: Jonathan Wakely <jwakely dot gcc at gmail dot com>
To: "libstdc++" <libstdc++ at gcc dot gnu dot org>, gcc-patches <gcc-patches at gcc dot gnu dot org>
Date: Fri, 9 Mar 2018 01:09:46 +0000
Subject: Use non-throwing is_directory in filesystem::create_directory
Authentication-results: sourceware.org; auth=none

The create_dir helper was calling the throwing form of
filesystem::is_directory instead of passing the error_code argument.
Since std::filesystem::create_directory(const path&, error_code&) is
noexcept, it would call std::terminate if an error occurred in
is_directory.

Passing the error_code also takes care of clearing it in the case where
is_directory returns true.

            src/filesystem/ops.cc (create_dir): Pass error_code to is_directory.
            src/filesystem/std-ops.cc (create_dir): Likewise.

Tested powerpc64le-linux, committed to trunk.

Attachment: patch.txt
Description: Text document

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]