This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Avoid dumping fancy names in -fcompare-debug dumps (PR c++/84704)
- From: Jeff Law <law at redhat dot com>
- To: Jakub Jelinek <jakub at redhat dot com>, Richard Biener <rguenther at suse dot de>, Alexandre Oliva <aoliva at redhat dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Tue, 6 Mar 2018 15:56:01 -0700
- Subject: Re: [PATCH] Avoid dumping fancy names in -fcompare-debug dumps (PR c++/84704)
- Authentication-results: sourceware.org; auth=none
- References: <20180306204755.GA5867@tucnak>
On 03/06/2018 01:47 PM, Jakub Jelinek wrote:
> Hi!
>
> As discussed, e.g. gimplification of STATEMENT_LISTs can create extra
> retval.N temporaries for -g and get the counts out of sync, similarly
> the SAVE_EXPR change proposed in the fix for that PR could for decls
> in the statement expressions or addresses thereof get the fancy names
> counters out of sync.
>
> The following patch marks the temporaries DECL_NAMELESS in addition to
> DECL_IGNORED_P and in the dumps used for -fcompare-debug checking
> prints those as D.xxxx rather than retval.234.
>
> Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk?
>
> 2018-03-06 Jakub Jelinek <jakub@redhat.com>
>
> PR c++/84704
> * gimple-expr.c (create_tmp_var_raw): Set DECL_NAMELESS flag
> on tmp_var.
> * tree-pretty-print.c (dump_decl_name): For TDF_COMPARE_DEBUG,
> don't print names of DECL_NAMELESS DECL_IGNORED_P decls.
OK.
jeff