This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH, rs6000] Tests for builtin vec_neg updated
- From: Segher Boessenkool <segher at kernel dot crashing dot org>
- To: Carl Love <cel at us dot ibm dot com>
- Cc: gcc-patches at gcc dot gnu dot org, David Edelsohn <dje dot gcc at gmail dot com>, Bill Schmidt <wschmidt at linux dot vnet dot ibm dot com>
- Date: Mon, 26 Feb 2018 11:24:24 -0600
- Subject: Re: [PATCH, rs6000] Tests for builtin vec_neg updated
- Authentication-results: sourceware.org; auth=none
- References: <1519314070.3293.10.camel@us.ibm.com>
Hi Carl,
On Thu, Feb 22, 2018 at 07:41:10AM -0800, Carl Love wrote:
> * gcc.target/powerpc/builtins-3.c: Move vec_neg builtin tests to
> Power 8 test file.
> * gcc.target/powerpc/builtins-3-p8.c: Add vec_neg builtin tests.
> * gcc.target/powerpc/fold-vec-neg-char.c(dg-options): Add -mcpu=power8.
> * gcc.target/powerpc/fold-vec-neg-floatdouble.c(dg-options): Add
> -mcpu=power8.
> * gcc.target/powerpc/fold-vec-neg-int.c(dg-options): Remove file.
> * gcc.target/powerpc/fold-vec-neg-short.c(dg-options): Add
> -mcpu=power8.
You should use a space before ( there.
> + test_neg_char 1 vspltisw, 1 vsububm
> + test_neg_short 1 vspltisw, 1 vsubuhm
> + test_neg_int 1 vspltisw, 1 vsubuwm
All these are p6 already (so needs just -maltivec).
> + test_neg_float 1 xvnegsp
> + test_neg_float 1 xvnegdp
... and these are p7 (so needs just -mvsx). I don't understand why you
move them to a p8 file? Or ah, this is because the builtin is not
defined before p8? Okay for trunk if so :-)
Thanks,
Segher