This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [patch, fortran] Fix character length in constructors

From: Thomas Koenig <tkoenig at netcologne dot de>
To: Janne Blomqvist <blomqvist dot janne at gmail dot com>
Cc: "fortran at gcc dot gnu dot org" <fortran at gcc dot gnu dot org>, gcc-patches <gcc-patches at gcc dot gnu dot org>
Date: Tue, 20 Feb 2018 19:59:34 +0100
Subject: Re: [patch, fortran] Fix character length in constructors
Authentication-results: sourceware.org; auth=none
References: <a4470f1d-a946-a5bf-7934-5ef8e88ac3d9@netcologne.de> <CAO9iq9EdSx-07ni3CbBrUzxnVLme-ynSfTrt-r+D_zx95PgU8Q@mail.gmail.com>

Am 20.02.2018 um 08:51 schrieb Janne Blomqvist:

It's better to use gfc_mpz_get_hwi() instead of mpz_get_si().
mpz_get_si() returns a long, which is a 32-bit type on win64.

Otherwise Ok with the spelling fix suggested by Steve.


Committed as r257856.

Thanks to you and Steve for the review and the heads_up about
gfc_mpz_get_hwi.

I also changed the "call abort" to "STOP 1" at the last second
(old habits are hard to break, it seems :-)

Regards

	Thomas

Follow-Ups:
- Re: [patch, fortran] Fix character length in constructors
  - From: Janne Blomqvist

References:
- [patch, fortran] Fix character length in constructors
  - From: Thomas Koenig
- Re: [patch, fortran] Fix character length in constructors
  - From: Janne Blomqvist

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]