This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [Patch, fortran] PR84074 Incorrect indexing of array when actual argument is an array expression and dummy is polymorphic
- From: Paul Richard Thomas <paul dot richard dot thomas at gmail dot com>
- To: Steve Kargl <sgk at troutmask dot apl dot washington dot edu>
- Cc: "dominiq at lps dot ens.fr" <gcc-bugzilla at gcc dot gnu dot org>, "fortran at gcc dot gnu dot org" <fortran at gcc dot gnu dot org>, gcc-patches <gcc-patches at gcc dot gnu dot org>
- Date: Sun, 11 Feb 2018 18:30:03 +0000
- Subject: Re: [Patch, fortran] PR84074 Incorrect indexing of array when actual argument is an array expression and dummy is polymorphic
- Authentication-results: sourceware.org; auth=none
- References: <CAGkQGiJ84HX5yPK+HsN40VgSoy1zjy8kU8QeTrbTZdfENLSd-w@mail.gmail.com> <20180211163758.GB27561@troutmask.apl.washington.edu>
Committed as revision 257564 with the comment reworded.
Thanks
Paul
On 11 February 2018 at 16:37, Steve Kargl
<sgk@troutmask.apl.washington.edu> wrote:
> On Sun, Feb 11, 2018 at 03:08:52PM +0000, Paul Richard Thomas wrote:
>>
>> PR fortran/84074
>> * trans-expr.c (gfc_conv_derived_to_class): Set the use_offset
>> flag. If the is a vector subscript or the expression is not a
>> variable, make the descriptor one-based.
>
>
> "If the is a" ?
>
>> +
>> + /* Vector array references and non-variable expressions need be
>> + coverted to one-based descriptors. */
>
> s/coverted/converted
>
>
> OK with the above fixed.
>
> --
> steve
--
"If you can't explain it simply, you don't understand it well enough"
- Albert Einstein