This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH][GRAPHITE] Fix PR71351
- From: Richard Biener <rguenther at suse dot de>
- To: Tom de Vries <Tom_deVries at mentor dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Tue, 19 Dec 2017 14:05:59 +0100 (CET)
- Subject: Re: [PATCH][GRAPHITE] Fix PR71351
- Authentication-results: sourceware.org; auth=none
- References: <alpine.LSU.2.20.1709211204180.26836@zhemvz.fhfr.qr> <51f6adfb-adfa-e562-c2d7-42f3bffc6d94@mentor.com>
On Tue, 19 Dec 2017, Tom de Vries wrote:
> On 09/21/2017 12:07 PM, Richard Biener wrote:
> > - exit_edge = create_empty_if_region_on_edge (entry_edge,
> > - unshare_expr (cond_expr));
>
> This removes the fix for PR70045:
> ...
> diff --git a/gcc/graphite-isl-ast-to-gimple.c
> b/gcc/graphite-isl-ast-to-gimple.c
> index 89a4118..8dd5dc8 100644
> --- a/gcc/graphite-isl-ast-to-gimple.c
> +++ b/gcc/graphite-isl-ast-to-gimple.c
> @@ -821,7 +821,8 @@ graphite_create_new_loop_guard (edge entry_edge,
> if (integer_onep (cond_expr))
> exit_edge = entry_edge;
> else
> - exit_edge = create_empty_if_region_on_edge (entry_edge, cond_expr);
> + exit_edge = create_empty_if_region_on_edge (entry_edge,
> + unshare_expr (cond_expr));
>
> return exit_edge;
> }
> ...
>
>
> Consequently, the pr70045.c testcase is currently ICE-ing.
Sorry.
> Attached patch fixes this.
>
> OK for trunk if bootstrap and reg-test on x86_64 succeed?
Ok.
Richard.