This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Verify allowed stmts before labels
- From: Jeff Law <law at redhat dot com>
- To: Jakub Jelinek <jakub at redhat dot com>, Richard Biener <rguenther at suse dot de>, Alexandre Oliva <aoliva at redhat dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Wed, 13 Dec 2017 10:49:42 -0700
- Subject: Re: [PATCH] Verify allowed stmts before labels
- Authentication-results: sourceware.org; auth=none
- References: <20171213141249.GH2353@tucnak>
On 12/13/2017 07:12 AM, Jakub Jelinek wrote:
> Hi!
>
> PR83391/PR83396 failed because debug bind stmts were put before labels.
> Alex said that is undesirable, and that right now we want to allow
> just debug begin stmt markers before or intermixed with labels.
>
> This patch ensures that through verification, which is what defines
> what is and isn't valid GIMPLE. If we ever reconsider it, either allow
> further stmts or disallow even debug begin stmt markers, we can easily also
> tweak the verifier. The patch has been successfully bootstrapped/regtested as
> part of the:
>
> https://gcc.gnu.org/ml/gcc-patches/2017-12/msg00811.html
> https://gcc.gnu.org/ml/gcc-patches/2017-12/msg00808.html
> https://gcc.gnu.org/bugzilla/attachment.cgi?id=42861
> https://gcc.gnu.org/bugzilla/attachment.cgi?id=42866
> https://gcc.gnu.org/ml/gcc-patches/2017-12/msg00794.html
>
> patchset, without the msg00811.html patch it of course doesn't survive
> bootstrap, as we insert debug bind stmts before labels in those cases.
>
> Ok for trunk once the msg00811.html patch or something similar is committed?
>
> 2017-12-13 Jakub Jelinek <jakub@redhat.com>
>
> * tree-cfg.c (verify_gimple_in_cfg): Verify no non-label stmts
> with the exception of debug begin stmt markers appear before
> labels.
OK.
jeff