This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH][GCC][ARM] Fix failing testcase pragma_fpu_attribute.c
- From: Christophe Lyon <christophe dot lyon at linaro dot org>
- To: Tamar Christina <tamar dot christina at arm dot com>
- Cc: "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>, nd <nd at arm dot com>, Ramana Radhakrishnan <Ramana dot Radhakrishnan at arm dot com>, Richard Earnshaw <Richard dot Earnshaw at arm dot com>, nick clifton <nickc at redhat dot com>, Kyrylo Tkachov <Kyrylo dot Tkachov at arm dot com>
- Date: Mon, 11 Dec 2017 10:01:33 +0100
- Subject: Re: [PATCH][GCC][ARM] Fix failing testcase pragma_fpu_attribute.c
- Authentication-results: sourceware.org; auth=none
- References: <20171208145315.GA25009@arm.com>
On 8 December 2017 at 15:53, Tamar Christina <tamar.christina@arm.com> wrote:
> Hi All,
>
> My previous patch had two issues with the new test cases.
> It seems that depending on which DejaGnu version you have
> dg-additional-options will add the options before or after the
> ones added by the test suite. Which means I can't use it to override
> the default options.
>
> For this I use a pragma now and place the pragma before GCC needs to emit
> any code. Which in turn means it doesn't emit the .fpu directive for the first
> switching of fpus.
>
> Secondly, because of the usage of neon I also need to guard against arm_neon_ok.
>
> Regtested on arm-none-eabi and no regressions.
>
> Ok for trunk?
>
>
> gcc/testsuite/
> 2017-12-08 Tamar Christina <tamar.christina@arm.com>
>
> PR target/82641
> * gcc.target/arm/pragma_fpu_attribute.c: New.
> * gcc.target/arm/pragma_fpu_attribute_2.c: New.
>
> --
Hi Tamar,
We must be testing/building differently, since your patch doesn't work for me.
The compiler complains when including arm_neon.h because:
"NEON intrinsics not available with the soft-float ABI."
I'm using a recent dejagnu (1.6+). and for instance on arm-none-eabi,
the testcase
is compiled with -std=gnu99, but no other ABI-related option. Why does
it work for you?
Christophe