This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
RE: [PATCH][GCC][ARM] Generate .arch and .arch_extensions for each function if required. [Patch (3/3)]
- From: Tamar Christina <Tamar dot Christina at arm dot com>
- To: Christophe Lyon <christophe dot lyon at linaro dot org>
- Cc: "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>, nd <nd at arm dot com>, Ramana Radhakrishnan <Ramana dot Radhakrishnan at arm dot com>, Richard Earnshaw <Richard dot Earnshaw at arm dot com>, "nickc at redhat dot com" <nickc at redhat dot com>, "Kyrylo Tkachov" <Kyrylo dot Tkachov at arm dot com>
- Date: Fri, 8 Dec 2017 11:19:03 +0000
- Subject: RE: [PATCH][GCC][ARM] Generate .arch and .arch_extensions for each function if required. [Patch (3/3)]
- Authentication-results: sourceware.org; auth=none
- Authentication-results: spf=none (sender IP is ) smtp.mailfrom=Tamar dot Christina at arm dot com;
- Nodisclaimer: True
- References: <20171106165200.GA12194@arm.com> <HE1PR08MB05076132D7E6DC037FB79F0BFF230@HE1PR08MB0507.eurprd08.prod.outlook.com> <HE1PR08MB0507C38B8E311DE410E52B97FF390@HE1PR08MB0507.eurprd08.prod.outlook.com> <CAKdteOYZiVGQ7cfkG7+GAgSn0CH1PdxmZ0AHnR6+0JLqazkFBw@mail.gmail.com>
- Spamdiagnosticmetadata: NSPM
- Spamdiagnosticoutput: 1:99
Hi Christoph,
> >> > gcc/testsuite/
> >> > 2017-11-06 Tamar Christina <tamar.christina@arm.com>
> >> >
> >> > PR target/82641
> >> > * gcc.target/arm/pragma_arch_attribute_2.c: New.
> >> > * gcc.target/arm/pragma_arch_attribute_2.c: New.
> >> > * gcc.target/arm/pragma_arch_attribute_3.c: New.
> >> > * gcc.target/arm/pragma_fpu_attribute.c: New.
> >> > * gcc.target/arm/pragma_fpu_attribute_2.c: New.
> >> >
> >> > --
>
> I'm afraid you'll have to update the testcases: they fail on non-hf targets
> (arm-none-linux-gnueabi, arm-none-eabi), because:
> In file included from /gcc/testsuite/gcc.target/arm/pragma_fpu_attribute.c:7:
> /aci-gcc-fsf/builds/gcc-fsf-gccsrc/obj-arm-none-linux-
> gnueabi/gcc3/gcc/include/arm_neon.h:31:2:
> error: #error "NEON intrinsics not available with the soft-float ABI.
> Please use -mfloat-abi=softfp or -mfloat-abi=hard"
> /gcc/testsuite/gcc.target/arm/pragma_fpu_attribute.c:11:53: error:
> unknown type name 'poly64x1_t'
> /gcc/testsuite/gcc.target/arm/pragma_fpu_attribute.c:11:71: error:
> unknown type name 'poly64x1_t'
Well this is incredibly frustrating. I tested these configurations repeatedly locally:
Test Run By tnfchris on Thu Dec 7 13:39:54 2017
Target is arm-none-eabi
Host is x86_64-pc-linux-gnu
/d/t/g/s/gcc (arm-implement-pragma-arch-verify ↩☡) grep "pragma_fpu_attribute\.c" ../../build-arm-none-eabi/results/vanilla/gcc.sum
PASS: gcc.target/arm/pragma_fpu_attribute.c (test for excess errors)
PASS: gcc.target/arm/pragma_fpu_attribute.c scan-assembler-times \\.fpu\\s+crypto-neon-fp-armv8 1
PASS: gcc.target/arm/pragma_fpu_attribute.c scan-assembler-times \\.fpu\\s+vfpv3-d16 1
PASS: gcc.target/arm/pragma_fpu_attribute.c (test for excess errors)
PASS: gcc.target/arm/pragma_fpu_attribute.c scan-assembler-times \\.fpu\\s+crypto-neon-fp-armv8 1
PASS: gcc.target/arm/pragma_fpu_attribute.c scan-assembler-times \\.fpu\\s+vfpv3-d16 1
--
Test Run By tnfchris on Thu Dec 7 11:08:29 2017
Native configuration is arm-none-linux-gnueabihf
tnfchris@native:~/gcc-arm$ grep "pragma_fpu_attribute\.c" ./gcc/testsuite/gcc/gcc.sum
PASS: gcc.target/arm/pragma_fpu_attribute.c (test for excess errors)
PASS: gcc.target/arm/pragma_fpu_attribute.c scan-assembler-times \\.fpu\\s+crypto-neon-fp-armv8 1
PASS: gcc.target/arm/pragma_fpu_attribute.c scan-assembler-times \\.fpu\\s+vfpv3-d16 1
So I'm quite surprised about this. In any case, I will look into it.
Thanks,
Tamar
>
> Looking at other attributes tests, maybe you need to add arm_neon_ok?
>
> Thanks,
> Christophe