This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [patch] prevent .cfi_personality/.cfi_lsda on !dwarf eh configurations
- From: Jeff Law <law at redhat dot com>
- To: Olivier Hainque <hainque at adacore dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Thu, 7 Dec 2017 15:57:39 -0700
- Subject: Re: [patch] prevent .cfi_personality/.cfi_lsda on !dwarf eh configurations
- Authentication-results: sourceware.org; auth=none
- References: <0C3F671C-A82F-49B7-9651-560578E02568@adacore.com>
On 11/30/2017 02:18 AM, Olivier Hainque wrote:
> Hello,
>
> Bootstrap is currently broken with Ada on x86_64-windows using SEH exceptions,
> with several stage2/stage3 object comparison failures like
>
> Bootstrap comparison failure!
> gcc/ada/ali-util.o differs
> gcc/ada/ali.o differs
> ...
>
> (PR 81470)
>
> The differences come from variations between -g and -g0 on the placement of
> data attached to LDFCM labels, in particular those related to the emission of
> .cfi_personality and .cfi_lsda by dwarf2out_do_cfi_startproc.
>
> These aren't needed for SEH anyway, so the proposed patch just prevents the
> generation of those .cfi notes if the target eh format isn't dwarf2.
>
> We have used this for a couple of years on gcc-6, it cures the same
> bootstrap failure on gcc-7, and bootstraps + regression-tests fine
> with mainline on x86_64-linux.
>
> OK to commit ?
>
> 2017-11-30 Tristan Gingold <gingold@adacore.com>
>
> * dwarf2out.c (dwarf2out_do_cfi_startproc): Only emit
> .cfi_personality or .cfi_lsda if the eh data format is dwarf2.
>
OK.
jeff