This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Add _Float<N>/_Float<N>X rounding built-ins & improve gimple optimization of _Float<N>/_Float<N>X built-in functions
- From: Segher Boessenkool <segher at kernel dot crashing dot org>
- To: Michael Meissner <meissner at linux dot vnet dot ibm dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>, David Edelsohn <dje dot gcc at gmail dot com>, Bill Schmidt <wschmidt at linux dot vnet dot ibm dot com>, Joseph Myers <joseph at codesourcery dot com>
- Date: Mon, 20 Nov 2017 11:32:08 -0600
- Subject: Re: [PATCH] Add _Float<N>/_Float<N>X rounding built-ins & improve gimple optimization of _Float<N>/_Float<N>X built-in functions
- Authentication-results: sourceware.org; auth=none
- References: <20171117050445.GA13927@ibm-tiger.the-meissners.org> <20171117140608.GV10515@gate.crashing.org> <20171118003505.GA20542@ibm-tiger.the-meissners.org>
Hi!
On Fri, Nov 17, 2017 at 07:35:05PM -0500, Michael Meissner wrote:
> Here is the fixed patch. It fixes the btrunc<mode>2 insn to use the correct
> XSRPQI variant for truncf128. I added the float128-hw11.c test as a runtime
> test to make sure round, trunc, ceil, and floor return the correct values. The
> machine independent portions are the same.
>
> Assuming the machine independent versions are approved, can I check in the
> PowerPC bits?
The rs6000 parts are okay, with a trivial fix:
> --- gcc/testsuite/gcc.target/powerpc/float128-hw11.c (revision 0)
> +++ gcc/testsuite/gcc.target/powerpc/float128-hw11.c (revision 0)
> @@ -0,0 +1,59 @@
> +/* { dg-do run { target { powerpc*-*-* && lp64 } } } */
> +/* { dg-require-effective-target powerpc_p9vector_ok } */
> +/* { dg-options "-mpower9-vector -O2" } */
> +/* { dg-options "-mvsx -O2" } */
This last line should not be there.
Thanks,
Segher