This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH][RFC] Instrument function exit with __builtin_unreachable in C++.
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Martin Liška <mliska at suse dot cz>
- Cc: Eric Botcazou <ebotcazou at adacore dot com>, gcc-patches at gcc dot gnu dot org, Jason Merrill <jason at redhat dot com>, Marek Polacek <polacek at redhat dot com>, Jonathan Wakely <jwakely at redhat dot com>
- Date: Wed, 15 Nov 2017 11:04:28 +0100
- Subject: Re: [PATCH][RFC] Instrument function exit with __builtin_unreachable in C++.
- Authentication-results: sourceware.org; auth=none
- References: <31ddd79e-1152-9dd9-663b-acd8d1bcd4ab@suse.cz> <806d7d62-1de5-128e-67e6-4b740c70d3b4@suse.cz> <20171115080726.GP14653@tucnak> <1609793.XEM2eeOWNW@polaris> <6afecad7-1289-1665-6dba-cd4dd70644b2@suse.cz>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Wed, Nov 15, 2017 at 10:54:23AM +0100, Martin Liška wrote:
> gcc/c/ChangeLog:
>
> 2017-11-15 Martin Liska <mliska@suse.cz>
>
> * c-decl.c (grokdeclarator):
> Compare warn_return_type for greater than zero.
> (start_function): Likewise.
> (finish_function): Likewise.
> * c-typeck.c (c_finish_return): Likewise.
>
> gcc/cp/ChangeLog:
>
> 2017-11-15 Martin Liska <mliska@suse.cz>
>
> * decl.c (finish_function):
> Compare warn_return_type for greater than zero.
> * semantics.c (finish_return_stmt): Likewise.
The c/cp changes aren't really needed, are they? Because
in that case you guarantee in the post options handling it is
0 or 1.
The rest looks good (except for Ada that Eric doesn't want to change).
Jakub