This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
Igor > -----Original Message----- > From: H.J. Lu [mailto:hjl.tools@gmail.com] > Sent: Wednesday, November 8, 2017 7:18 PM > To: Tsimbalist, Igor V <igor.v.tsimbalist@intel.com> > Cc: Jeff Law <law@redhat.com>; gcc-patches@gcc.gnu.org; > triegel@redhat.com > Subject: Re: [PATCH 21/22] Add extra field to gtm_jmpbuf on x86 only > > On Tue, Nov 7, 2017 at 8:22 AM, Tsimbalist, Igor V > <igor.v.tsimbalist@intel.com> wrote: > > I decided to split my previous patch "Enable building libitm with Intel CET " > > into two different patches. The first patch will add a new field to sjlj.S and > > target.h files. The second one will add Intel CET support on the top of the > > first one. In this case the further changes for adding Intel CET support are > > seen clearly. > > > > Ok for trunk? > > > > libitm/configure.tgt should check ${target} like the other places: > > +# Update libtool_VERSION since the size of struct gtm_jmpbuf is > +# changed for x86. > +case "${host}" in > > Did these come from cut and paste? > > + # For x86, we use slots in the TCB head for most of our TLS. > + # The setup of those slots in beginTransaction can afford to > + # use the global-dynamic model. > > I think the whole thing should be: > > case "${target}" in > # Update libtool_VERSION since the size of struct gtm_jmpbuf is > # changed for x86. > i[456]86-*-* | x86_64-*-*) > libtool_VERSION=2:0:0 > ;; > esac There was a feedback from Joseph (email attached) with the comment about similar case in cet.m4: > This file is checking $target. That's only ever appropriate in directories > building compilers and similar tools; target library directories should check > $host, as the host for target libraries is the target for the compiler. Igor > > > > -- > H.J.
--- Begin Message ---
- From: "Tsimbalist, Igor V" <igor dot v dot tsimbalist at intel dot com>
- To: Joseph Myers <joseph at codesourcery dot com>
- Cc: "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>, Jeff Law <law at redhat dot com>, "ian at airs dot com" <ian at airs dot com>, "Tsimbalist, Igor V" <igor dot v dot tsimbalist at intel dot com>
- Date: Thu, 12 Oct 2017 23:02:01 +0000
- Subject: RE: [PATCH 07/22] Enable building libgcc with CET options.
- Accept-language: en-US
- Dlp-product: dlpe-windows
- Dlp-reaction: no-action
- Dlp-version: 11.0.0.116
- References: <D511F25789BA7F4EBA64C8A63891A00291F42230@IRSMSX102.ger.corp.intel.com> <alpine.DEB.2.20.1710122032490.4373@digraph.polyomino.org.uk>
> -----Original Message----- > From: Joseph Myers [mailto:joseph@codesourcery.com] > Sent: Thursday, October 12, 2017 10:36 PM > To: Tsimbalist, Igor V <igor.v.tsimbalist@intel.com> > Cc: gcc-patches@gcc.gnu.org; Jeff Law <law@redhat.com>; ian@airs.com > Subject: Re: [PATCH 07/22] Enable building libgcc with CET options. > > On Thu, 12 Oct 2017, Tsimbalist, Igor V wrote: > > > Enable building libgcc with CET options by default on Linux/x86 if > > binutils supports CET v2.0. > > It can be disabled with --disable-cet. It is an error to configure > > GCC with --enable-cet if bintuiils doesn't support CET v2.0. > > > > config/ > > * cet.m4: New file > > This file is checking $target. That's only ever appropriate in directories > building compilers and similar tools; target library directories should check > $host, as the host for target libraries is the target for the compiler. Fixed. > This file has a comment > > > +dnl GCC_CET_LIBRARY > > +dnl (SHELL-CODE_HANDLER) > > which doesn't seem to match the subsequent definition of GCC_CET_FLAGS. Fixed. > I don't see any documentation of the new configure option. I'd expect the > first patch adding such an option to document it in install.texi, and then > subsequent patches to update that documentation if those patches extend > the option to cover more things. Added the description of this configure option to install.texi. The updated patch is attached. Igor > -- > Joseph S. Myers > joseph@codesourcery.comAttachment: 0007-Enable-building-libgcc-with-CET-options.patch
Description: 0007-Enable-building-libgcc-with-CET-options.patch
--- End Message ---
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |