This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix up predicates for commutative vector comparison (PR target/82855)


> The issues fixed by the previous patch together with this one result
> in the testcase from the PR with -mtune=intel (for some reason with
> generic tuning we decide to perform the 256-bit load as 2 128-bit loads and
> don't merge that into 256-bit comparison operand, shall we change that?)
> to use memory operand directly in vcmpeq* instead of loading it into a
> register first.
>
> Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk?
>
> 2017-11-06  Jakub Jelinek  <jakub@redhat.com>
>
> PR target/82855
> * config/i386/sse.md (<avx512>_eq<mode>3<mask_scalar_merge_name>_1):
> Use nonimmediate_operand predicate for operand 1 instead of
> register_operand.

Please also change operand1 of corresponding expanders to nonimmediate_operand.

OK with the above change.

Thanks,
Uros.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]