[PATCH] Further -Wreturn-type testsuite fallout

[Jakub Jelinek <jakub at redhat dot com>]

On Mon, Nov 06, 2017 at 03:12:00PM +0100, Martin Liška wrote:
> On 11/06/2017 02:58 PM, Paolo Carlini wrote:
> > Hi,
> > 
> > On 06/11/2017 14:37, Martin Liška wrote:
> >> Thank you for the patch.
> >> I'm going to install the remaining part that will fix x86_64 fallout. All changes are
> >> quite obvious, so hope it's fine to install it.
> > I think so. Thanks.
> > 
> > Note that the 3 additional libstdc++-v3 changes aren't really necessary, but those testcases are failing, seg faulting, at run time for unrelated reasons. I don't know if Jonathan is already on that...
> > 
> > Paolo.
> 
> You're right, it started right when it was introduced in r254008.
> 
> I see:
> 
> g++ libstdc++-v3/testsuite/27_io/basic_ifstream/cons/char/path.cc -std=gnu++17 -I. -lstdc++fs && ./a.out
> libstdc++-v3/testsuite/27_io/basic_ifstream/cons/char/path.cc:33: void test01(): Assertion 'f.is_open()' failed.
> Aborted (core dumped)

I'm seeing also:
+FAIL: g++.dg/pr50763-3.C  -std=gnu++11 (test for excess errors)
+FAIL: g++.dg/pr50763-3.C  -std=gnu++14 (test for excess errors)
+FAIL: g++.dg/pr50763-3.C  -std=gnu++98 (test for excess errors)
+FAIL: g++.dg/pr57878.C  -std=gnu++11 (test for excess errors)
+FAIL: g++.dg/pr57878.C  -std=gnu++14 (test for excess errors)
on i686-linux.  The following patch fixes that and I've additionally
verified the testcases even with the changes ICE as before with
revisions before the fixes and work after those (and with current trunk).

Ok for trunk?

2017-11-06  Jakub Jelinek  <jakub@redhat.com>

	* g++.dg/pr57878.C (__sso_string_base::_M_get_allocator): Return
	a value.
	* g++.dg/pr50763-3.C (sExt::evalPoint): Likewise.

--- gcc/testsuite/g++.dg/pr57878.C.jj	2014-03-10 10:49:55.000000000 +0100
+++ gcc/testsuite/g++.dg/pr57878.C	2017-11-06 22:04:24.166063301 +0100
@@ -95,6 +95,8 @@ namespace __gnu_cxx __attribute__ ((__vi
     }
     __sso_string_base(const __sso_string_base& __rcs);
     const _CharT_alloc_type& _M_get_allocator() const {
+      static _CharT_alloc_type c;
+      return c;
     }
   };
   template<typename _CharT, typename _Traits, typename _Alloc>
--- gcc/testsuite/g++.dg/pr50763-3.C.jj	2011-11-04 07:49:39.000000000 +0100
+++ gcc/testsuite/g++.dg/pr50763-3.C	2017-11-06 21:59:48.983471233 +0100
@@ -54,4 +54,5 @@ long sExt::evalPoint(const v2d & crUV, v
       sUV = _Dom.clp2d(crUV);
    }
    eval();
+   return 0;
 }   


	Jakub