This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH][compare-elim] Fix PR rtl-optimization/82597
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Richard Biener <rguenther at suse dot de>, Jeff Law <law at redhat dot com>, Eric Botcazou <ebotcazou at adacore dot com>, Michael Collison <Michael dot Collison at arm dot com>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>, nd <nd at arm dot com>
- Date: Tue, 31 Oct 2017 23:15:31 +0100
- Subject: Re: [PATCH][compare-elim] Fix PR rtl-optimization/82597
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx03.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx03.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=jakub at redhat dot com
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 343B283F46
- References: <AM4PR0802MB2371D4E9BD5A123C10DF4C6C95430@AM4PR0802MB2371.eurprd08.prod.outlook.com> <20171031093559.GS14653@tucnak> <20171031110226.GT14653@tucnak>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Tue, Oct 31, 2017 at 12:02:26PM +0100, Jakub Jelinek wrote:
> 2017-10-31 Jakub Jelinek <jakub@redhat.com>
>
> PR rtl-optimization/82778
> PR rtl-optimization/82597
> * compare-elim.c (struct comparison): Add in_a_setter field.
> (find_comparison_dom_walker::before_dom_children): Remove killed
> bitmap and df_simulate_find_defs call, instead walk the defs.
> Compute last_setter and initialize in_a_setter. Merge definitions
> with first initialization for a few variables.
> (try_validate_parallel): Use insn_invalid_p instead of
> recog_memoized. Return insn rather than just the pattern.
> (try_merge_compare): Fix up comment. Don't uselessly test if
> in_a is a REG_P. Use cmp->in_a_setter instead of walking UD
> chains.
>
> * g++.dg/opt/pr82778.C: New test.
>
> 2017-10-31 Michael Collison <michael.collison@arm.com>
>
> PR rtl-optimization/82597
> * gcc.dg/pr82597.c: New test.
Successfully bootstrapped/regtested on {x86_64,i686,powerpc64{,le}}-linux.
Ok for trunk?
Jakub