RE: [PATCH 07/22] Enable building libgcc with CET options.

["Tsimbalist, Igor V" <igor dot v dot tsimbalist at intel dot com>]

The revised patch is attached. The differences are in what options are defined and propagated to Makefile for CET enabling, also needed asm files are updated.

Igor


> -----Original Message-----
> From: Tsimbalist, Igor V
> Sent: Friday, October 13, 2017 1:02 AM
> To: Joseph Myers <joseph@codesourcery.com>
> Cc: gcc-patches@gcc.gnu.org; Jeff Law <law@redhat.com>; ian@airs.com;
> Tsimbalist, Igor V <igor.v.tsimbalist@intel.com>
> Subject: RE: [PATCH 07/22] Enable building libgcc with CET options.
> 
> > -----Original Message-----
> > From: Joseph Myers [mailto:joseph@codesourcery.com]
> > Sent: Thursday, October 12, 2017 10:36 PM
> > To: Tsimbalist, Igor V <igor.v.tsimbalist@intel.com>
> > Cc: gcc-patches@gcc.gnu.org; Jeff Law <law@redhat.com>; ian@airs.com
> > Subject: Re: [PATCH 07/22] Enable building libgcc with CET options.
> >
> > On Thu, 12 Oct 2017, Tsimbalist, Igor V wrote:
> >
> > > Enable building libgcc with CET options by default on Linux/x86 if
> > > binutils supports CET v2.0.
> > > It can be disabled with --disable-cet.  It is an error to configure
> > > GCC with --enable-cet if bintuiils doesn't support CET v2.0.
> > >
> > > config/
> > > 	* cet.m4: New file
> >
> > This file is checking $target.  That's only ever appropriate in directories
> > building compilers and similar tools; target library directories should check
> > $host, as the host for target libraries is the target for the compiler.
> 
> Fixed.
> 
> > This file has a comment
> >
> > > +dnl GCC_CET_LIBRARY
> > > +dnl    (SHELL-CODE_HANDLER)
> >
> > which doesn't seem to match the subsequent definition of
> GCC_CET_FLAGS.
> 
> Fixed.
> 
> > I don't see any documentation of the new configure option.  I'd expect the
> > first patch adding such an option to document it in install.texi, and then
> > subsequent patches to update that documentation if those patches extend
> > the option to cover more things.
> 
> Added the description of this configure option to install.texi.
> 
> The updated patch is attached.
> 
> Igor
> 
> > --
> > Joseph S. Myers
> > joseph@codesourcery.com

Attachment: 0007-Enable-building-libgcc-with-CET-options.patch
Description: 0007-Enable-building-libgcc-with-CET-options.patch