This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PING][PATCH][Aarch64] Improve int<->FP conversions

From: James Greenhalgh <james dot greenhalgh at arm dot com>
To: Michael Collison <Michael dot Collison at arm dot com>
Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>, nd <nd at arm dot com>
Date: Thu, 26 Oct 2017 13:56:54 +0100
Subject: Re: [PING][PATCH][Aarch64] Improve int<->FP conversions
Authentication-results: sourceware.org; auth=none
Authentication-results: spf=pass (sender IP is 217.140.96.140) smtp.mailfrom=arm.com; gcc.gnu.org; dkim=none (message not signed) header.d=none;gcc.gnu.org; dmarc=bestguesspass action=none header.from=arm.com;
Nodisclaimer: True
References: <HE1PR0802MB237756521326110B20F2F70F957E0@HE1PR0802MB2377.eurprd08.prod.outlook.com> <20170929225711.GA22958@arm.com> <HE1PR0802MB2377A400EF19C60B23F7B4D5957C0@HE1PR0802MB2377.eurprd08.prod.outlook.com> <20171004093919.GA28210@arm.com> <HE1PR0802MB2377A9D6453F9BA16410803E954C0@HE1PR0802MB2377.eurprd08.prod.outlook.com> <20171023164319.GA18098@arm.com> <HE1PR0802MB23772DD97F6DF1020824E7B895470@HE1PR0802MB2377.eurprd08.prod.outlook.com>
Spamdiagnosticmetadata: NSPM
Spamdiagnosticoutput: 1:99

On Tue, Oct 24, 2017 at 10:47:32PM +0100, Michael Collison wrote:
> James,
> 
> The patch was test as required. However when I tested with the latest trunk there were two test failures that need to be updated because of my patch. 
> 
> The files gcc.target/aarch64/vect-vcvt.c was failing because the scan-assembler directives assumed the destination register was assumed to be an integer register. With my patch the destination can be an integer or fp register.
> 
> I fixed the failures and bootstrapped and tested on aarch64-linux-gnu. Okay for trunk?

OK.

> --- a/gcc/testsuite/gcc.target/aarch64/vect-vcvt.c
> +++ b/gcc/testsuite/gcc.target/aarch64/vect-vcvt.c
> @@ -56,13 +56,13 @@ TEST (SUFFIX, q, 32, 4, u,u,s)			\
>  TEST (SUFFIX, q, 64, 2, u,u,d)			\
>  
>  BUILD_VARIANTS ( )
> -/* { dg-final { scan-assembler "fcvtzs\\tw\[0-9\]+, s\[0-9\]+" } } */
> -/* { dg-final { scan-assembler "fcvtzs\\tx\[0-9\]+, d\[0-9\]+" } } */
> +/* { dg-final { scan-assembler "fcvtzs\\t(w|s)\[0-9\]+, s\[0-9\]+" } } */
> +/* { dg-final { scan-assembler "fcvtzs\\t(x|d)\[0-9\]+, d\[0-9\]+" } } */
>  /* { dg-final { scan-assembler "fcvtzs\\tv\[0-9\]+\.2s, v\[0-9\]+\.2s" } } */
>  /* { dg-final { scan-assembler "fcvtzs\\tv\[0-9\]+\.4s, v\[0-9\]+\.4s" } } */
>  /* { dg-final { scan-assembler "fcvtzs\\tv\[0-9\]+\.2d, v\[0-9\]+\.2d" } } */
> -/* { dg-final { scan-assembler "fcvtzu\\tw\[0-9\]+, s\[0-9\]+" } } */
> -/* { dg-final { scan-assembler "fcvtzu\\tx\[0-9\]+, d\[0-9\]+" } } */
> +/* { dg-final { scan-assembler "fcvtzu\\t(w|s)\[0-9\]+, s\[0-9\]+" } } */
> +/* { dg-final { scan-assembler "fcvtzu\\t(x|d)\[0-9\]+, d\[0-9\]+" } } */
>  /* { dg-final { scan-assembler "fcvtzu\\tv\[0-9\]+\.2s, v\[0-9\]+\.2s" } } */
>  /* { dg-final { scan-assembler "fcvtzu\\tv\[0-9\]+\.4s, v\[0-9\]+\.4s" } } */
>  /* { dg-final { scan-assembler "fcvtzu\\tv\[0-9\]+\.2d, v\[0-9\]+\.2d" } } */

Personally I'd have used \[ws\] but this works too.

Reviewed by: James Greenhalgh <james.greenhalgh@arm.com>

James

References:
- RE: [PING][PATCH][Aarch64] Improve int<->FP conversions
  - From: Michael Collison
- Re: [PING][PATCH][Aarch64] Improve int<->FP conversions
  - From: James Greenhalgh
- RE: [PING][PATCH][Aarch64] Improve int<->FP conversions
  - From: Michael Collison
- Re: [PING][PATCH][Aarch64] Improve int<->FP conversions
  - From: James Greenhalgh
- RE: [PING][PATCH][Aarch64] Improve int<->FP conversions
  - From: Michael Collison

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]