This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [RFC PATCH, i386]: Make FP inequality comparisons trapping on qNaN.
On Fri, Oct 20, 2017 at 9:48 PM, Uros Bizjak <ubizjak@gmail.com> wrote:
> On Fri, Oct 20, 2017 at 2:15 PM, Joseph Myers <joseph@codesourcery.com> wrote:
>
>> This is PR target/52451.
>>
>> A testcase (conditional on the fenv_exceptions effective-target) that
>> ordered comparisons with quiet NaNs set FE_INVALID would be a good idea,
>> but it would need XFAILing for powerpc (bug 58684) and s390 (bug 77918).
>
> Joseph,
>
> thanks for pointing out a PR reference and a suggestion for a testcase.
>
> Please find attached a new version of the patch, including the
> comprehensive tests.
>
> 2017-10-20 Uros Bizjak <ubizjak@gmail.com>
>
> PR target/52451
> * config/i386/i386.c (ix86_fp_compare_mode): Return CCFPmode
> for ordered inequality comparisons even with TARGET_IEEE_FP.
>
> 2017-10-20 Uros Bizjak <ubizjak@gmail.com>
>
> PR target/52451
> * gcc.dg/torture/pr52451.c: New test.
>
> Bootstrapped and regression tested on x86_64-linux-gnu {,-m32}.
Now committed to mainline SVN.
Uros.