This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
[PATCH] Fix nrv-1.c false failure on aarch64.
- From: Egeyar Bagcioglu <egeyar dot bagcioglu at oracle dot com>
- To: gcc-patches at gcc dot gnu dot org
- Date: Wed, 18 Oct 2017 18:59:13 +0200
- Subject: [PATCH] Fix nrv-1.c false failure on aarch64.
- Authentication-results: sourceware.org; auth=none
Hello,
Test case "guality.exp=nrv-1.c" fails on aarch64. Optimizations reorder
the instructions and cause the value of a variable to be checked before
its first assignment. The following patch is moving the
break point to the end of the function. Therefore, it ensures that the
break point is reached after the assignment instruction is executed.
Please review the patch and apply if legitimate.
Egeyar
>From a11fe0b1fcf1867a0fa8c4627e347bda07a4c61b Mon Sep 17 00:00:00 2001
From: Egeyar Bagcioglu <egeyar.bagcioglu@oracle.com>
Date: Thu, 12 Oct 2017 06:16:30 -0700
Subject: [PATCH] Fix nrv-1.c false failure on aarch64.
Reordering instructions due to optimization flags is causing nrv-1.c
to fail on aarch64. The value of the variable is checked before the
assignment instruction is reached. This patch is moving the
breakpoint to the end of the function to prevent such false failures.
* gcc.dg/guality/nrv-1.c: Move breakpoint from line 20 to 22.
---
gcc/testsuite/gcc.dg/guality/nrv-1.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/gcc/testsuite/gcc.dg/guality/nrv-1.c b/gcc/testsuite/gcc.dg/guality/nrv-1.c
index 2f4e654..77ad462 100644
--- a/gcc/testsuite/gcc.dg/guality/nrv-1.c
+++ b/gcc/testsuite/gcc.dg/guality/nrv-1.c
@@ -17,9 +17,9 @@ f ()
a2.i[0] = 42;
if (a3.i[0] != 0)
abort ();
- a2.i[4] = 7; /* { dg-final { gdb-test 20 "a2.i\[0\]" "42" } } */
+ a2.i[4] = 7;
return a2;
-}
+} /* { dg-final { gdb-test 22 "a2.i\[0\]" "42" } } */
int
main ()
--
1.9.1