This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH 4/9] [SFN] introduce statement frontier notes, still disabled
- From: Alexandre Oliva <aoliva at redhat dot com>
- To: Richard Biener <richard dot guenther at gmail dot com>
- Cc: Jason Merrill <jason at redhat dot com>, nathan at acm dot org, GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Tue, 17 Oct 2017 18:51:22 -0200
- Subject: Re: [PATCH 4/9] [SFN] introduce statement frontier notes, still disabled
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx07.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx07.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=aoliva at redhat dot com
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com C5590C0467FE
- References: <orefqoy2u9.fsf@lxoliva.fsfla.org> <20170930090827.6604-4-aoliva@redhat.com> <CAFiYyc1qKLmf3KN6stb3gwOVP04pPi3yw8juGzdH-bswq+YtCQ@mail.gmail.com> <orefq75x9b.fsf@lxoliva.fsfla.org> <CAFiYyc2hGx4+VV89aSvf=n+N_1W5nDD0vw5P51oYVoZHav4aFw@mail.gmail.com>
On Oct 13, 2017, Richard Biener <richard.guenther@gmail.com> wrote:
> If the [SFN] is self-contained you can install that part once the approval
> for the FE parts is in.
It is, so I'll do that.
> You can of course wait a bit for more reviews
> (stopped short on LVU because of that all-targets touching patch ... ;))
:-)
I could minimize the amount of visible changes in target code by using
'&' rather than '*' to make the parameter changeable. This enables
final_start_function to consume the initial debug insns, so that
e.g. parm bindings are integrated in the initial view.
The per-target changes could also be avoided entirely, by having both
final_start_function and final skip initial debug insns, but I think
that is wasteful, cpu-wise, and error prone in the long term,
maintenance-wise.
Just throwing some options out, in case touching the code of so many
targets turns out to be a blocker...
--
Alexandre Oliva, freedom fighter http://FSFLA.org/~lxoliva/
You must be the change you wish to see in the world. -- Gandhi
Be Free! -- http://FSFLA.org/ FSF Latin America board member
Free Software Evangelist|Red Hat Brasil GNU Toolchain Engineer