This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH, RFC] Add a pass counter for "are we there yet" purposes


On October 16, 2017 5:46:35 PM GMT+02:00, Sandra Loosemore <sandra@codesourcery.com> wrote:
>On 10/16/2017 12:53 AM, Richard Biener wrote:
>> On October 16, 2017 7:38:50 AM GMT+02:00, Sandra Loosemore
><sandra@codesourcery.com> wrote:
>>> This patch is a first cut at solving the problem discussed in this
>>> thread
>>>
>>> https://gcc.gnu.org/ml/gcc/2017-10/msg00016.html
>>>
>>> where I have some nios2 backend patches in my queue that need a way
>of
>>> knowing whether the split1 pass has run yet.  There seemed to be
>>> agreement that a general way to query the pass manager for this
>>> information would be useful.
>>>
>>> [snip]
>>
>> I missed the post of why you need to know this. But as you noticed
>we're using reload_completed for similar purpose. There's also the
>possibility of setting/adding a pass property that split could provide
>and which you could query. We're using this to signal the various
>different lowering stages in GIMPLE for example.
>
>See the thread linked above.  There was interest in a general mechanism
>
>to query the pass manager state instead of adding the bookkeeping to
>the 
>nios2 backend or adding something to track the split1 pass to the 
>target-independent parts of the compiler.  After fiddling with it, 
>though, I'm not sure this is an improvement.
>
>Maybe it would help the discussion if I got my nios2 patch set posted
>so 
>that everybody could see the actual use case?  It'll take me a few days
>
>to finish cleaning it up.

I guess that might help. I have the feeling that querying for 'did pass X run' is wrong conceptually. 

Richard. 

>-Sandra


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]