This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Prevent invalid register mode changes in combine
- From: Jeff Law <law at redhat dot com>
- To: gcc-patches at gcc dot gnu dot org, richard dot sandiford at linaro dot org
- Date: Thu, 12 Oct 2017 12:36:49 -0600
- Subject: Re: Prevent invalid register mode changes in combine
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx06.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx06.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=law at redhat dot com
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 6101E3DBC0
- References: <87bmm8grsj.fsf@linaro.org>
On 09/18/2017 05:38 AM, Richard Sandiford wrote:
> This patch stops combine from changing the mode of an existing register
> in-place if doing so would change the size of the underlying register
> allocation size, as given by REGMODE_NATURAL_SIZE. Without this,
> many tests fail in adjust_reg_mode after SVE is added. One example
> is gcc.c-torture/compile/20090401-1.c.
>
> Tested on aarch64-linux-gnu, x86_64-linux-gnu and powerpc64le-linux-gnu.
> Also tested by comparing the testsuite assembly output on at least one
> target per CPU directory. OK to install?
>
> Richard
>
>
> 2017-09-18 Richard Sandiford <richard.sandiford@linaro.org>
> Alan Hayward <alan.hayward@arm.com>
> David Sherwood <david.sherwood@arm.com>
>
> gcc/
> * combine.c (can_change_dest_mode): Reject changes in
> REGMODE_NATURAL_SIZE.
OK.
jeff