This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH][mingw] Enable colorized diagnostics

From: JonY <10walls at gmail dot com>
To: Liu Hao <lh_mouse at 126 dot com>, Joseph Myers <joseph at codesourcery dot com>
Cc: gcc-patches at gcc dot gnu dot org
Date: Wed, 11 Oct 2017 13:34:55 +0000
Subject: Re: [PATCH][mingw] Enable colorized diagnostics
Authentication-results: sourceware.org; auth=none
References: <7a71ece2.2bf.15ec4a65660.Coremail.lh_mouse@126.com> <alpine.DEB.2.20.1709272008360.32152@digraph.polyomino.org.uk> <ec5058b5-a0fd-75d7-2307-fb1354d0b63e@126.com> <223ab272-26b9-6079-df18-8c5da0031c2f@gmail.com> <c7d75e16-edee-3a5c-c818-a3911eb6913c@126.com>

On 10/09/2017 01:07 PM, Liu Hao wrote:
> On 2017/10/9 19:01, JonY wrote:
>> On 10/08/2017 11:39 AM, Liu Hao wrote:
>>
>> I'm not sure if it should be enabled by default due to the interleaving
>> problem, but seeing as the user has to go out to set GCC_COLORS to use
>> this feature, I suppose it is OK.
>>
>> I will commit soon if there are no more comments.
>>
>>
> 
> Thank you. By the way I noticed a mistake in the comments above
> `find_esc_terminator()`. This function returns zero on failure like its
> `find_esc_head()` counterpart, while the comments mistakenly referred
> -1. Please correct it before committing.
> 
> 

Committed to trunk r253645 with the appropriate change.

Attachment: signature.asc
Description: OpenPGP digital signature

References:
- Re: [PATCH][mingw] Enable colorized diagnostics
  - From: Liu Hao
- Re: [PATCH][mingw] Enable colorized diagnostics
  - From: JonY
- Re: [PATCH][mingw] Enable colorized diagnostics
  - From: Liu Hao

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]