This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Do not error for no_sanitize attributes (PR sanitizer/82490).
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Markus Trippelsdorf <markus at trippelsdorf dot de>
- Cc: Martin Liška <mliska at suse dot cz>, gcc-patches at gcc dot gnu dot org
- Date: Wed, 11 Oct 2017 09:54:59 +0200
- Subject: Re: [PATCH] Do not error for no_sanitize attributes (PR sanitizer/82490).
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx02.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx02.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=jakub at redhat dot com
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 4AF69820EE
- References: <e7055dbf-47ac-71fb-e30b-6721711d280b@suse.cz> <20171011073949.GJ14653@tucnak> <20171011074527.GD13028@x4>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Wed, Oct 11, 2017 at 09:45:27AM +0200, Markus Trippelsdorf wrote:
> On 2017.10.11 at 09:39 +0200, Jakub Jelinek wrote:
> > On Wed, Oct 11, 2017 at 08:24:28AM +0200, Martin Liška wrote:
> > > Hi.
> > >
> > > This changes error to a warning:
> > > warning: ‘foobar’ attribute directive ignored [-Wattributes]
> > >
> > > Patch can bootstrap on ppc64le-redhat-linux and survives regression tests.
> >
> > What is the rationale for not warning? LLVM compatibility?
> > I think in some cases it would be nice to find out that I wrote a typo...
>
> The patch does warn. But yes, not erroring out improves LLVM
> compatibility. Chromium uses __attribute__(no_sanitize("function")) for
> example.
Ah, ok. The patch is ok with the nit testcase fixed.
Jakub