This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH][PR sanitizer/77631] Support separate debug info in libbacktrace
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Martin Liška <mliska at suse dot cz>
- Cc: Ian Lance Taylor <iant at google dot com>, Denis Khalikov <d dot khalikov at partner dot samsung dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Mon, 2 Oct 2017 16:01:20 +0200
- Subject: Re: [PATCH][PR sanitizer/77631] Support separate debug info in libbacktrace
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx01.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx01.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=jakub at redhat dot com
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com EF9F181E16
- References: <CGME20170616153942eucas1p1945271f893265484bbb3991a368bcd92@eucas1p1.samsung.com> <2b505c8c-a836-6079-f744-3e9f8acf9356@partner.samsung.com> <CAKOQZ8zCqEFeD8HearTze4YUGRASH3u-v8_dRAgsOBTg70i3bA@mail.gmail.com> <9396366a-47ab-899c-cbcb-e79af1338869@partner.samsung.com> <CAKOQZ8yvRxm7icH-aNa=aKw-aGnTtRgLo_t-fTN9CPaXjrWSoA@mail.gmail.com> <CAKOQZ8wHa8UX-T-S6fY=q69LVtzVF0oETuCGSvc+o3hF0Lmyqw@mail.gmail.com> <ffdfc32d-18c0-b579-91d1-9a890960c807@suse.cz> <20171002113201.GV1701@tucnak>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Mon, Oct 02, 2017 at 01:32:01PM +0200, Jakub Jelinek wrote:
> On Mon, Oct 02, 2017 at 01:12:24PM +0200, Martin Liška wrote:
> > Hi.
> >
> > Currently I see with --with-build-config=bootstrap-ubsan:
> >
> > /home/marxin/BIG/buildbot/slave/gcc-master-bootstrap-ubsan/build/builddir/prev-x86_64-pc-linux-gnu/libsanitizer/ubsan/.libs/libubsan.a(elf.o): In function `backtrace_uncompress_zdebug':
> > /home/marxin/BIG/buildbot/slave/gcc-master-bootstrap-ubsan/build/builddir/x86_64-pc-linux-gnu/libsanitizer/libbacktrace/../../.././../libsanitizer/libbacktrace/../../libbacktrace/elf.c:2489: multiple definition of `backtrace_uncompress_zdebug'
> > ../libbacktrace/.libs/libbacktrace.a(elf.o):/home/marxin/BIG/buildbot/slave/gcc-master-bootstrap-ubsan/build/builddir/libbacktrace/.././../libbacktrace/elf.c:2489: first defined here
> > collect2: error: ld returned 1 exit status
> > make[3]: *** [Makefile:2904: gcov] Error 1
> > make[3]: *** Waiting for unfinished jobs....
>
> I think this should fix it, I'm going to bootstrap/regtest this now (though
> not --with-build-config=bootstrap-ubsan).
>
> 2017-10-02 Jakub Jelinek <jakub@redhat.com>
>
> * libbacktrace/backtrace-rename.h (backtrace_uncompress_zdebug):
> Define.
Committed as obvious after bootstrap/regtest on x86_64-linux and i686-linux.
>
> --- libsanitizer/libbacktrace/backtrace-rename.h.jj 2014-09-25 15:01:25.000000000 +0200
> +++ libsanitizer/libbacktrace/backtrace-rename.h 2017-10-02 13:30:23.096271411 +0200
> @@ -11,6 +11,7 @@
> #define backtrace_qsort __asan_backtrace_qsort
> #define backtrace_release_view __asan_backtrace_release_view
> #define backtrace_syminfo __asan_backtrace_syminfo
> +#define backtrace_uncompress_zdebug __asan_backtrace_uncompress_zdebug
> #define backtrace_vector_finish __asan_backtrace_vector_finish
> #define backtrace_vector_grow __asan_backtrace_vector_grow
> #define backtrace_vector_release __asan_backtrace_vector_release
Jakub