This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [committed][PATCH] Stack clash protection patch 02b/08 - V4
- From: Jeff Law <law at redhat dot com>
- To: Joseph Myers <joseph at codesourcery dot com>
- Cc: gcc-patches <gcc-patches at gcc dot gnu dot org>
- Date: Wed, 20 Sep 2017 16:08:01 -0600
- Subject: Re: [committed][PATCH] Stack clash protection patch 02b/08 - V4
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx06.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx06.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=law at redhat dot com
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com D7F1E356D4
- References: <1a54a75f-368b-e087-7bdf-56fe8b5d57bc@redhat.com> <alpine.DEB.2.20.1709202102060.31948@digraph.polyomino.org.uk>
On 09/20/2017 03:02 PM, Joseph Myers wrote:
> This breaks the build for powerpcspe.
>
> powerpcspe:
> /scratch/jmyers/glibc-bot/src/gcc/gcc/config/powerpcspe/powerpcspe.c:29691:10: error: 'flag_stack_check_protection' was not declared in this scope
> || flag_stack_check_protection)
> ^
>
And the actual patch for the archives.
Jeff
commit 1a6b37e1d3962c9adc2e7e5fd14329f1b19ea6cf
Author: law <law@138bc75d-0d04-0410-961f-82ee72b054a4>
Date: Wed Sep 20 22:06:11 2017 +0000
* config/powerpcspe/powerpcspe.c (rs6000_expand_prologue): Fix
thinko in stack clash protection support.
git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/trunk@253036 138bc75d-0d04-0410-961f-82ee72b054a4
diff --git a/gcc/ChangeLog b/gcc/ChangeLog
index 9f0c821fc65..588542c6eef 100644
--- a/gcc/ChangeLog
+++ b/gcc/ChangeLog
@@ -1,5 +1,8 @@
2017-09-20 Jeff Law <law@redhat.com>
+ * config/powerpcspe/powerpcspe.c (rs6000_expand_prologue): Fix
+ thinko in stack clash protection support.
+
* explow.c (compute_stack_clash_protection_loop_data): Use
CONST_INT_P instead of explicit test. Verify object is a
CONST_INT_P before looking at INTVAL.
diff --git a/gcc/config/powerpcspe/powerpcspe.c b/gcc/config/powerpcspe/powerpcspe.c
index e235d3c6a82..c7ccda10f7b 100644
--- a/gcc/config/powerpcspe/powerpcspe.c
+++ b/gcc/config/powerpcspe/powerpcspe.c
@@ -29688,7 +29688,7 @@ rs6000_emit_prologue (void)
current_function_static_stack_size = info->total_size;
if (flag_stack_check == STATIC_BUILTIN_STACK_CHECK
- || flag_stack_check_protection)
+ || flag_stack_clash_protection)
{
HOST_WIDE_INT size = info->total_size;