Re: [PATCH] PR target/80556

[Simon Wright <simon at pushface dot org>]

On 18 Sep 2017, at 21:09, Iain Sandoe <iain@codesourcery.com> wrote:
> 
> Hi Simon,
> 
>> On 29 Jun 2017, at 21:41, Simon Wright <simon@pushface.org> wrote:
>> 
>> On 28 Jun 2017, at 18:40, Jeff Law <law@redhat.com> wrote:
>>> 
>>> On 06/09/2017 07:57 AM, Simon Wright wrote:
>>>>      2017-06-09 Simon Wright <simon@pushface.org>
>>>> 
>>>>      PR target/80556
>>>>      * configure.ac (stage1_ldflags): For Darwin, include -lSystem.
>>>>        (poststage1_ldflags): likewise.
>>>>      * configure: regenerated.
>>> I'm a bit confused here.  Isn't -lSystem included in darwin's LIB_SPEC
>>> in which case the right things ought to already be happening, shouldn't it?
>> 
>> The specs that involve -lSystem are
> 
>> I've rebuilt gcc-8-20170528 with this change alone (i.e. not the patch currently posted here), successfully.
>> 
>> If I propose this alternative patch, should it be a new post, or should I continue this thread?
> 
> thanks for the patch.
> 
> The basic idea seems sound - as a workaround (as noted in comment #20 in the PR, we should really rationalise the libgcc/crts stuff to reflect the modern world, but these things take time...).
> 
> The patch as you have it would apply to every version of Darwin.
> 
> AFAICT from the published sources, i386 Darwin should be able to work with the libgcc unwinder (and all earlier Darwin *have* to) - so I’ve proposed a modified patch in the PR that makes the changes specific to m64 x86 and doesn’t make any alteration for PPC and/or Darwin < 10.

That sounds like the right thing to do. I hadn't considered the older hardware/os issues (I only have kit back to macOS 10.11, Darwin 15).