This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH, PR81844] Fix condition folding in c_parser_omp_for_loop
- From: Jakub Jelinek <jakub at redhat dot com>
- To: "de Vries, Tom" <Tom_deVries at mentor dot com>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>, "Schwinge, Thomas" <Thomas_Schwinge at mentor dot com>
- Date: Thu, 14 Sep 2017 21:38:41 +0200
- Subject: Re: [PATCH, PR81844] Fix condition folding in c_parser_omp_for_loop
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx08.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx08.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=jakub at redhat dot com
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 3B563C0035D0
- References: <8d91b179-6873-2988-529b-705e123010cf@mentor.com> <20170914105503.GH1701@tucnak> <1505417653837.14909@mentor.com>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Thu, Sep 14, 2017 at 07:34:14PM +0000, de Vries, Tom wrote:
> --- a/libgomp/testsuite/libgomp.c++/c++.exp
> +++ b/libgomp/testsuite/libgomp.c++/c++.exp
> @@ -22,6 +22,11 @@ dg-init
> # Turn on OpenMP.
> lappend ALWAYS_CFLAGS "additional_flags=-fopenmp"
>
> +# Switch into C++ mode. Otherwise, the libgomp.c-c++-common/*.c
> +# files would be compiled as C files.
> +set SAVE_GCC_UNDER_TEST "$GCC_UNDER_TEST"
> +set GCC_UNDER_TEST "$GCC_UNDER_TEST -x c++"
> +
> set blddir [lookfor_file [get_multilibs] libgomp]
>
>
> @@ -47,7 +52,9 @@ if { $blddir != "" } {
>
> if { $lang_test_file_found } {
> # Gather a list of all tests.
> - set tests [lsort [find $srcdir/$subdir *.C]]
> + set tests [lsort [concat \
> + [find $srcdir/$subdir *.C] \
> + [find $srcdir/$subdir/../libgomp.c-c++-common *.c]]]
>
> if { $blddir != "" } {
> set ld_library_path "$always_ld_library_path:${blddir}/${lang_library_path}"
I don't see SAVE_GCC_UNDER_TEST being used anywhere after it is set.
Did you mean to set GCC_UNDER_TEST back to SAVE_GCC_UNDER_TEST at the end of
c++.exp?
libgomp.oacc-c++/c++.exp has:
# See above.
set GCC_UNDER_TEST "$SAVE_GCC_UNDER_TEST"
Otherwise LGTM, thanks.
Jakub