This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Improve alloca alignment
- From: Wilco Dijkstra <Wilco dot Dijkstra at arm dot com>
- To: Eric Botcazou <ebotcazou at adacore dot com>, Rainer Orth <ro at CeBiTec dot Uni-Bielefeld dot DE>
- Cc: "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>, Jeff Law <law at redhat dot com>, nd <nd at arm dot com>
- Date: Fri, 8 Sep 2017 22:49:15 +0000
- Subject: Re: [PATCH] Improve alloca alignment
- Authentication-results: sourceware.org; auth=none
- Authentication-results: spf=none (sender IP is ) smtp.mailfrom=Wilco dot Dijkstra at arm dot com;
- Nodisclaimer: True
- References: <DB6PR0801MB2053EFC180A8360BC943BEB883B90@DB6PR0801MB2053.eurprd08.prod.outlook.com> <152e8e72-c654-846a-c383-5c935c5af6ae@redhat.com> <yddzia8w8s2.fsf@CeBiTec.Uni-Bielefeld.DE>,<28942318.eoPupIDytn@polaris>
- Spamdiagnosticmetadata: NSPM
- Spamdiagnosticoutput: 1:99
Eric Botcazou wrote:
> The stack is aligned before the allocation but it gets misaligned during the
> allocation because the dynamic offset is not a multiple of STACK_BOUNDARY.
No, the stack never gets misaligned - my patch doesn't change that at all. The issue is that Sparc backend doesn't correctly set STACK_BOUNDSARY and neither aligns the outgoing args. Run my test which proves alloca was broken before my patch.
Wilco