This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Fix IPA ICF with ASM statements (PR inline-asm/82001).
- From: Richard Biener <richard dot guenther at gmail dot com>
- To: Martin Liška <mliska at suse dot cz>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Wed, 30 Aug 2017 11:18:02 +0200
- Subject: Re: [PATCH] Fix IPA ICF with ASM statements (PR inline-asm/82001).
- Authentication-results: sourceware.org; auth=none
- References: <ac6fe8f6-5e16-1a5f-ae1b-193a50f03065@suse.cz>
On Wed, Aug 30, 2017 at 11:12 AM, Martin Liška <mliska@suse.cz> wrote:
> Hi.
>
> Following patch compares also constraints of input and output operands of ASM statements.
> Patch can bootstrap on ppc64le-redhat-linux and survives regression tests.
>
> Ready to be installed?
It's now no longer "compare_tree_list_operand" but compare_asm_constraint
where there's no need to walk TREE_CHAIN either.
So can you refactor this a bit?
> Martin
>
> gcc/ChangeLog:
>
> 2017-08-28 Martin Liska <mliska@suse.cz>
>
> PR inline-asm/82001
> * ipa-icf-gimple.c (func_checker::compare_tree_list_operand):
> Compare TREE_PURPOSE of asm inputs and outputs.
>
> gcc/testsuite/ChangeLog:
>
> 2017-08-28 Martin Liska <mliska@suse.cz>
>
> PR inline-asm/82001
> * gcc.dg/ipa/pr82001.c: New test.
> ---
> gcc/ipa-icf-gimple.c | 10 ++++++++++
> gcc/testsuite/gcc.dg/ipa/pr82001.c | 21 +++++++++++++++++++++
> 2 files changed, 31 insertions(+)
> create mode 100644 gcc/testsuite/gcc.dg/ipa/pr82001.c
>
>