This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [patch, libgfortran] PR78387 OpenMP segfault/stack size exceeded writing to internal file
- From: Jerry DeLisle <jvdelisle at charter dot net>
- To: "fortran at gcc dot gnu dot org" <fortran at gcc dot gnu dot org>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Sat, 26 Aug 2017 12:28:12 -0700
- Subject: Re: [patch, libgfortran] PR78387 OpenMP segfault/stack size exceeded writing to internal file
- Authentication-results: sourceware.org; auth=none
- References: <7a90e51a-70c1-e917-6a5a-32eff0b73e4f@charter.net>
ping - I will commit if I hear no objections.
Jerry
On 08/19/2017 10:12 PM, Jerry DeLisle wrote:
> Hi all,
>
> I have decided to simply delete the internal unit stack altogether.
>
> The original intent was to save time with internal unit I/O by avoiding
> reallocating a gfc_unit structure every time an internal unit (aka string) is
> used for I/O.
>
> After deleting and testing it appears no significant change in performance.
>
> Regression tested on x86_64-linux. No new test case.
>
> OK for trunk and then I think this should be backported to 7.
>
> Regards,
>
> Jerry
>
> 2017-08-20 Jerry DeLisle <jvdelisle@gcc.gnu.org>
>
> PR libgfortran/78387
> * io/list_read.c (nml_read_obj): Remove use of stash.
> * io/transfer.c (st_read_done, st_write_done): Likewise.
> * io/unit.c (stash_internal_unit): Delete function.
> (get_unit): Remove use of stash.
> (init_units): Likewise.
> (close_units): Likewise.
> * io/write.c (nml_write_obj): Likewise: