This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [77/77] Add a complex_mode class
- From: Jeff Law <law at redhat dot com>
- To: gcc-patches at gcc dot gnu dot org, richard dot sandiford at linaro dot org
- Date: Fri, 25 Aug 2017 10:48:37 -0600
- Subject: Re: [77/77] Add a complex_mode class
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx07.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx07.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=law at redhat dot com
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com C2E3FC04B94A
- References: <8760ewohsv.fsf@linaro.org> <87wp7caeqq.fsf@linaro.org>
On 07/13/2017 03:05 AM, Richard Sandiford wrote:
> This patch adds another machine_mode wrapper for modes that are
> known to be COMPLEX_MODE_P. There aren't yet many places that make
> use of it, but that might change in future.
>
> 2017-07-13 Richard Sandiford <richard.sandiford@linaro.org>
> Alan Hayward <alan.hayward@arm.com>
> David Sherwood <david.sherwood@arm.com>
>
> gcc/
> * coretypes.h (complex_mode): New type.
> * gdbhooks.py (build_pretty_printer): Handle it.
> * machmode.h (complex_mode): New class.
> (complex_mode::includes_p): New function.
> (is_complex_int_mode): Likewise.
> (is_complex_float_mode): Likewise.
> * genmodes.c (get_mode_class): Handle complex mode classes.
> * function.c (expand_function_end): Use is_complex_int_mode.
>
> gcc/go/
> * go-lang.c (go_langhook_type_for_mode): Use is_complex_float_mode.
OK.
I think that's the whole set. I want to go back and review the API
issue raised early in the kit, but otherwise I don't see any concerns.
Obviously the trunk has continued to evolve since the kit was posted.
It's safe to assume there'll be minor updates as a result -- I trust
your judgment on addressing any such fallout without going through
another review cycle.
Jeff