This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [46/77] Make widest_int_mode_for_size return a scalar_int_mode
- From: Jeff Law <law at redhat dot com>
- To: gcc-patches at gcc dot gnu dot org, richard dot sandiford at linaro dot org
- Date: Wed, 23 Aug 2017 22:27:50 -0600
- Subject: Re: [46/77] Make widest_int_mode_for_size return a scalar_int_mode
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx01.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx01.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=law at redhat dot com
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 6A34F81DE5
- References: <8760ewohsv.fsf@linaro.org> <87mv88g1id.fsf@linaro.org>
On 07/13/2017 02:54 AM, Richard Sandiford wrote:
> The comment for widest_int_mode said that it returns "the widest integer
> mode no wider than SIZE", but it actually returns the widest integer
> mode that is narrower than SIZE. In practice SIZE is always greater
> than 1, so it can always pick QImode in the worst case. The VOIDmode
> paths seem to be dead.
>
> gcc/
> 2017-07-13 Richard Sandiford <richard.sandiford@linaro.org>
> Alan Hayward <alan.hayward@arm.com>
> David Sherwood <david.sherwood@arm.com>
>
> * expr.c (widest_int_mode_for_size): Make the comment match the code.
> Return a scalar_int_mode and assert that the size is greater than
> one byte.
> (by_pieces_ninsns): Update accordingly and remove VOIDmode handling.
> (op_by_pieces_d::op_by_pieces_d): Likewise.
> (op_by_pieces_d::run): Likewise.
> (can_store_by_pieces): Likewise.
OK.
jeff