This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [42/77] Use scalar_int_mode in simplify_shift_const_1
- From: Jeff Law <law at redhat dot com>
- To: gcc-patches at gcc dot gnu dot org, richard dot sandiford at linaro dot org
- Date: Wed, 16 Aug 2017 11:27:04 -0600
- Subject: Re: [42/77] Use scalar_int_mode in simplify_shift_const_1
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx01.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx01.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=law at redhat dot com
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 5EC3A78899
- References: <8760ewohsv.fsf@linaro.org> <874lughg53.fsf@linaro.org>
On 07/13/2017 02:53 AM, Richard Sandiford wrote:
> This patch makes simplify_shift_const_1 use scalar_int_modes
> for all code that is specific to scalars rather than vectors.
> This includes situations in which the new shift mode is different
> from the original one, since the function never changes the mode
> of vector shifts. That in turn makes it more natural to test for
> equal modes in simplify_shift_const_1 rather than try_widen_shift_mode
> (which only applies to scalars).
>
> 2017-07-13 Richard Sandiford <richard.sandiford@linaro.org>
> Alan Hayward <alan.hayward@arm.com>
> David Sherwood <david.sherwood@arm.com>
>
> gcc/
> * combine.c (try_widen_shift_mode): Move check for equal modes to...
> (simplify_shift_const_1): ...here. Use scalar_int_mode for
> shift_unit_mode and for modes involved in scalar shifts.
OK.
Jeff