This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [40/77] Use scalar_int_mode for extraction_insn fields
- From: Jeff Law <law at redhat dot com>
- To: gcc-patches at gcc dot gnu dot org, richard dot sandiford at linaro dot org
- Date: Wed, 16 Aug 2017 11:05:29 -0600
- Subject: Re: [40/77] Use scalar_int_mode for extraction_insn fields
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx05.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx05.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=law at redhat dot com
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com B1202552F6
- References: <8760ewohsv.fsf@linaro.org> <87d194hg67.fsf@linaro.org>
On 07/13/2017 02:52 AM, Richard Sandiford wrote:
> insv, extv and eztzv modify or read a field in a register or
> memory. The field always has a scalar integer mode, while the
> register or memory either has a scalar integer mode or BLKmode.
> The mode of the bit position is also a scalar integer.
>
> This patch uses the type system to make that explicit.
>
> 2017-07-13 Richard Sandiford <richard.sandiford@linaro.org>
> Alan Hayward <alan.hayward@arm.com>
> David Sherwood <david.sherwood@arm.com>
>
> gcc/
> * optabs-query.h (extraction_insn::struct_mode): Change type to
> opt_scalar_int_mode and update comment.
> (extraction_insn::field_mode): Change type to scalar_int_mode.
> (extraction_insn::pos_mode): Likewise.
> * combine.c (make_extraction): Update accordingly.
> * optabs-query.c (get_traditional_extraction_insn): Likewise.
> (get_optab_extraction_insn): Likewise.
> * recog.c (simplify_while_replacing): Likewise.
> * expmed.c (narrow_bit_field_mem): Chane the type of the mode
> parameter to opt_scalar_int_mode.
s/Chane/Change/ in the ChangeLog.
OK.
jeff