This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] [i386,testsuite] [PR 71958] Error on -mx32 with -mabi=ms
- From: Rainer Orth <ro at CeBiTec dot Uni-Bielefeld dot DE>
- To: Daniel Santos <daniel dot santos at pobox dot com>
- Cc: gcc-patches <gcc-patches at gcc dot gnu dot org>, Uros Bizjak <ubizjak at gmail dot com>, "H . J . Lu" <hjl dot tools at gmail dot com>, Mike Stump <mikestump at comcast dot net>
- Date: Sat, 12 Aug 2017 16:16:05 +0200
- Subject: Re: [PATCH] [i386,testsuite] [PR 71958] Error on -mx32 with -mabi=ms
- Authentication-results: sourceware.org; auth=none
- References: <20170811212744.30180-1-daniel.santos@pobox.com>
Hi Daniel,
> We currently error when -mx32 -mabi=sysv and we encounter a function
> with attribute ms_abi, but we are not erroring on -mx32 and -mabi=ms
> (either explicitly or when it is the default on Windows). In fact, it
> generates code that runs, but is of an undfined ABI.
>
> I'm running -m64 and -m32 tests now and will run x32 tests when those
> are done. Presuming that I've corrected all existing tests that do not
> filter out x32 target and there are no additional failures, is this OK
> for head?
>
> Thanks,
> Daniel
>
> gcc/ChangeLog:
> 2017-08-11 Daniel Santos <daniel.santos@pobox.com>
>
> * config/i386/i386.c (ix86_option_override_internal): Modify.
> (ix86_function_type_abi): Likewise.
those entries are pretty useless as they stand: you should state *what*
you changed.
Rainer
--
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University