This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH, Fortran] Support for legacy %FILL fields in STRUCTUREs
- From: Fritz Reese <fritzoreese at gmail dot com>
- To: Thomas Koenig <tkoenig at netcologne dot de>
- Cc: fortran <fortran at gcc dot gnu dot org>, gcc-patches <gcc-patches at gcc dot gnu dot org>
- Date: Thu, 10 Aug 2017 07:08:56 -0700
- Subject: Re: [PATCH, Fortran] Support for legacy %FILL fields in STRUCTUREs
- Authentication-results: sourceware.org; auth=none
- References: <CAE4aFAkoWZf_sE8WjQj1thsrY8F4nO7iq3xfUFaCJQW_rFQTLQ@mail.gmail.com> <7a4a64e8-a24f-8868-9d61-d781b942d9d0@netcologne.de>
I find them strange too... But as you say, they are needed for old
code, and some such code bases are quite large and/or have
uncooperative users or maintainers.
Committed with %qs throughout, thanks for review.
---
Fritz Reese
On Tue, Aug 1, 2017 at 11:29 AM, Thomas Koenig <tkoenig@netcologne.de> wrote:
> Hi Fritz,
>
>
>
>> Regtests on x86_64-redhat-linux. OK for trunk?
>
>
> Patch looks good in principle; I really find all these DEC extensions
> strange, but if they are needed for old code, why not?
>
> Just one point:
>
>> + gfc_error ("%s not allowed outside STRUCTURE at %C", "%FILL");
>
>
> This should have %qs (throughout the patch).
>
> OK for trunk with that.
>
> Regards
>
> Thomas