This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
[C++ Patch Ping] Re: [C++ Patch] PR 79790 ("[C++17] ICE class template argument deduction")
- From: Paolo Carlini <paolo dot carlini at oracle dot com>
- To: Nathan Sidwell <nathan at acm dot org>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
- Cc: Jason Merrill <jason at redhat dot com>
- Date: Fri, 4 Aug 2017 11:40:51 +0200
- Subject: [C++ Patch Ping] Re: [C++ Patch] PR 79790 ("[C++17] ICE class template argument deduction")
- Authentication-results: sourceware.org; auth=none
- References: <25e893cd-0bf5-4c5e-24b7-70daba6793dc@oracle.com> <5469528a-e9ef-6f81-849d-e7321de6a14b@acm.org>
Hi,
On 14/07/2017 19:51, Nathan Sidwell wrote:
On 07/14/2017 01:32 PM, Paolo Carlini wrote:
While working on the bug I also noticed that we can simplify a bit
the code
generating the implicit deduction guides: if I'm not mistaken, when
we pass
types as first argument of build_deduction_guide - for implicit
guides, that is
- the deduction guide is never explicit. thus DECL_NONCONVERTING_P is
never
true. It's an unrelated tweak, anyway, which we can consider applying
by itself
if we don't change the code generating the implicit deduction guides.
I recall wondering the same thing when adding the 'elided = true'
pieces, but didn't investigate enough to confirm/deny. Thanks for
getting this.
You are welcome!
I think the rest of the patch - the bug fix proper - still awaits a
review...
Thanks!
Paolo.